Christopher B
4/29/24, 2:23:01 PM EDT
Yeah want to remove all redirects but I am worried about relative links. Like ./page2.html in /home/page2.html vs /homepage2.html
Christopher B
4/29/24, 2:23:55 PM EDT
So I think we will just need to start being super specific on links. Like always resolve to /home and /home/page2.html
Ian M
4/29/24, 2:38:52 PM EDT
it's Admin.check404 that is doing the redirect based on findWelcomePage
Ian M
4/29/24, 6:00:31 PM EDT
I can't figure this out - maybe tomorrow I can steal you for a bit. It's redirecting more, not less lol
Ian M
4/29/24, 6:05:09 PM EDT
If I don't run <path-action name="HtmlEditor.check404" alltypes="true" />
in the base/_site.xconf everything breaks completely - it just triggers downloads that never finish and nothing renders at all
Ian M
4/29/24, 6:28:34 PM EDT
We should get the unit tests for core working - they don't run right now, I'm playing with it
Ian M
4/30/24, 2:45:41 PM EDT
On another note - do you happen to remember why you added case '\n':
output.append("
"); break; to UrlUtilities.xmlEscape - I'm working on openedit and that is breaking the text editor currently. I don't want to revert it if you need it somewhere else - can add a different method instead or something
"); break; to UrlUtilities.xmlEscape - I'm working on openedit and that is breaking the text editor currently. I don't want to revert it if you need it somewhere else - can add a different method instead or something
Ian M
4/30/24, 2:46:27 PM EDT
It's removing line feeds if the text goes into a <textarea></textarea> as it's obviously not parsing
into a line feed
into a line feed
Ian M
4/30/24, 2:48:37 PM EDT
<textarea class="form-control" rows="30" id="content" name="content" rows="10">$editorSession.getEscapedSource()</textarea>
Ian M
4/30/24, 3:11:16 PM EDT
Ok I have figued out why you did it - there is a better fix with CSS, going to revert that change to fix the file manager.
Christopher B
4/30/24, 4:59:42 PM EDT
Ian M
On another note - do you happen to remember why you added case '\n':
output.append("
"); break; to UrlUtilities.xmlEscape - I'm working on openedit and that is breaking the text editor currently. I don't want to revert it if you need it somewhere else - can add a different method instead or something
"); break; to UrlUtilities.xmlEscape - I'm working on openedit and that is breaking the text editor currently. I don't want to revert it if you need it somewhere else - can add a different method instead or something
Yeah we should have that be only for HTML display not for textareas
Christopher B
4/30/24, 5:01:05 PM EDT
Does anyone want to work together? https://zoom.us/j/92493430061?pwd=OEI4a3JyZkx2V2tQWFZPT2c5Q2xMZz09
Christopher B
4/30/24, 5:14:32 PM EDT
Ian M
Ok I have figued out why you did it - there is a better fix with CSS, going to revert that change to fix the file manager.
Except we dont like the way pre is formated. Would rather not use it. Maybe have textarea use a new escape sequence?
Christopher B
4/30/24, 5:16:11 PM EDT
Ian M
If I don't run <path-action name="HtmlEditor.check404" alltypes="true" />
in the base/_site.xconf everything breaks completely - it just triggers downloads that never finish and nothing renders at all
Did you figure it out?